Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/455?usp=email
to review the following change.
Change subject: Cache mbed TLS dependency and build latest 2.x mbed TLS as well
......................................................................
Cache mbed TLS dependency and build latest 2.x mbed TLS as well
Change-Id: I39fb3f05b6245af9ae5dd666bfc53ed07e5cfb24
---
M .github/workflows/build.yaml
1 file changed, 23 insertions(+), 7 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/55/455/1
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index cd72f3d..c1f42dd 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -366,8 +366,8 @@
fail-fast: false
matrix:
os: [ubuntu-22.04]
- ssllib: [mbedtls3]
build: [ normal, asan ]
+ mbedtlsver: [ v3.5.1, v2.28.6 ]
include:
- build: asan
cflags: "-fsanitize=address -fno-sanitize-recover=all
-fno-optimize-sibling-calls -fsanitize-address-use-after-scope
-fno-omit-frame-pointer -g -O1"
@@ -378,29 +378,45 @@
ldflags: ""
cc: gcc
- name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} -
${{matrix.ssllib}}"
+ name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - mbed TLS
${{matrix.mbedtlsver}}"
runs-on: ${{matrix.os}}
env:
CFLAGS: ${{ matrix.cflags }}
LDFLAGS: ${{ matrix.ldflags }}
CC: ${{matrix.cc}}
UBSAN_OPTIONS: print_stacktrace=1
+ MBEDTLS_CFLAGS: -I/opt/mbedtls/include
+ MBEDTLS_LIBS: -L/opt/mbedtls/lib -lmbedtls -lmbedx509 -lmbedcrypto
steps:
- name: Install dependencies
run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev
liblz4-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils
python3-jinja2 python3-jsonschema libtool automake autoconf pkg-config
libcap-ng-dev libnl-genl-3-dev
- - name: "mbedtls: checkout"
+
+ - name: Cache mbed TLS
+ id: cache
+ uses: actions/cache@v3
+ with:
+ path: '/opt/mbedtls'
+ key: ${{ matrix.build
}}-mbedtls-${{matrix.mbedtlsver}}-${{matrix.cmakebuild}}
+ - name: "Mbed TLS: checkout"
uses: actions/checkout@v3
with:
path: mbedtls
repository: Mbed-TLS/mbedtls
- ref: v3.5.0
- - name: "mbedtls: make no_test"
+ ref: ${{ matrix.mbedtlsver}
+ if: steps.cache.outputs.cache-hit != 'true'
+ - name: "Mbed TLS: make no_test"
run: make -j3 no_test SHARED=1
working-directory: mbedtls
- - name: "mbedtls: make install"
- run: sudo make install DESTDIR=/usr
+ if: steps.cache.outputs.cache-hit != 'true'
+ - name: "Mbed TLS: make install"
+ run: sudo make install DESTDIR=/opt/mbedtls
working-directory: mbedtls
+ if: steps.cache.outputs.cache-hit != 'true'
+ - name: add /opt/mbedtls/lib to ld.so.conf.d
+ run: echo /opt/mbedtls/lib | sudo tee /etc/ld.so.conf.d/mbedtls.conf
+ - name: "ldconfig"
+ run: sudo ldconfig
- name: Checkout OpenVPN
uses: actions/checkout@v3
- name: autoconf
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/455?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I39fb3f05b6245af9ae5dd666bfc53ed07e5cfb24
Gerrit-Change-Number: 455
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
