Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/446?usp=email )
Change subject: Remove dead list test code ...................................................................... Patch Set 2: Code-Review-1 (3 comments) File tests/unit_tests/openvpn/test_misc.c: http://gerrit.openvpn.net/c/openvpn/+/446/comment/06c0770f_7c7fbf6a : PS2, Line 203: ASSERT(hash_add(hash, w->word, w, false)); Should probably use the cmocka assert_true here? http://gerrit.openvpn.net/c/openvpn/+/446/comment/57543554_99e77fac : PS2, Line 261: ASSERT(count == hash_n_elements(hash)); should use assert_int_equal http://gerrit.openvpn.net/c/openvpn/+/446/comment/0a20d288_80ec1771 : PS2, Line 268: hash_remove_by_value(nhash, (void *) i); can we test that this was successful? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/446?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I7511bc43cd6a0bcb89476f27d5822ab4a78d0d21 Gerrit-Change-Number: 446 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Mon, 11 Dec 2023 16:25:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
