Attention is currently required from: flichtenheld. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/476?usp=email )
Change subject: misc: make get_auth_challenge static ...................................................................... Patch Set 2: (1 comment) File src/openvpn/misc.c: http://gerrit.openvpn.net/c/openvpn/+/476/comment/12421107_520d82c3 : PS2, Line 143: if (auth_challenge) If moving this around anyway, we could convert this function to early-return, or even make it an ASSERT(auth_challenge) since the caller is only ever calling it from an "if (auth_challenge & ...") block... -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/476?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0abeec9f862aea1f6a8fdf350fa0008cf2e5d613 Gerrit-Change-Number: 476 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Tue, 12 Dec 2023 07:51:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
