Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/482?usp=email )
Change subject: tun.c: don't attempt to delete DNS and WINS servers if they're not set ...................................................................... Patch Set 1: (1 comment) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/482/comment/bcb4535d_4ecbfd8b : PS1, Line 19: However, due to bug we always attempted to remove DNS/WINS, > Why delete something that we haven't added? We have this logic (do not delete > if not added) for DNS6 […] Such a delay is the good reason I was looking for. Maybe could be added in a sentence to the commit message. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/482?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I21a36d24f8e213c780f55acbe3e4df555c93542a Gerrit-Change-Number: 482 Gerrit-PatchSet: 1 Gerrit-Owner: stipa <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: d12fk <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: stipa <[email protected]> Gerrit-Comment-Date: Mon, 18 Dec 2023 11:09:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: d12fk <[email protected]> Comment-In-Reply-To: stipa <[email protected]> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
