Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/454?usp=email )
Change subject: Fix unaligned access in macOS, FreeBSD, Solaris hwaddr ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: I still find this all horribly ugly, but this is not your fault... this API is bad enough (... on MacOS, it seems) but combined with C "undefined behaviour" rules there is no hope for sanity... That said, I have tested this on FreeBSD (works), NetBSD (works), OpenBSD (no AF_LINK provided, so, didn't work before, doesn't break anything now), MacOS (works) and OpenSolaris (no AF_LINK provided, but it compiles and tests fine). -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/454?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia797c8801fa9a9bc10b6674efde5fdbd7132e4a8 Gerrit-Change-Number: 454 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Sun, 31 Dec 2023 17:33:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel