Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/469?usp=email )
Change subject: Use mingw compile definition also to unit tests ...................................................................... Patch Set 3: (2 comments) File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/469/comment/b683acf6_b1411977 : PS3, Line 293: target_compile_options(${target} PRIVATE -municode -UUNICODE) > combining -municode with -UUNICODE and main(void) just means the -municode > has no effect at all. […] I updated the patch to only use the same defines but not the -municode. After looking up -U that it undefines UNICODE I am not really sure anymore why we use that for the normal mingw build. http://gerrit.openvpn.net/c/openvpn/+/469/comment/5b8769bf_b8607c4b : PS3, Line 666: target_compile_definitions(${test_name} PRIVATE -Dmain=wmain) > Yeah, just don't use -municode in the first place. Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/469?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie5aa643ab6190262f7c8b9e614bedb398e85859b Gerrit-Change-Number: 469 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Wed, 03 Jan 2024 14:40:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
