Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/486?usp=email )
Change subject: Allow having an extra function that is called when an env is freed ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: >From a cursory glance, the code looks OK. I'm not sure if we want it, though, >as it adds even more complexity to the env handling. For "we only want that for `--tls-export-cert` so the cert files +env produced are cumulative and the last call has them all", I think this is overdoing things - I do not think we had a single request to have "all certs in `--tls-verify`" and so balance feature <-> complexity goes more toward negative. If this cleans up other env-set related problems, that would be a different story. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/486?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6899c1af65fbd670d434cdb17f81c82b900bfbd4 Gerrit-Change-Number: 486 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Sat, 06 Jan 2024 16:22:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
