Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/490?usp=email
to review the following change.
Change subject: phase2_tcp_server: fix Coverity issue "Dereference after null
check"
......................................................................
phase2_tcp_server: fix Coverity issue "Dereference after null check"
As Coverity says:
Either the check against null is unnecessary, or there may be a null
pointer dereference.
In phase2_tcp_server: Pointer is checked against null but then
dereferenced anyway
The check is probably not required since we have an ASSERT(sig_info)
in the caller. But I really didn't want to remove the check. So
make the code consistent instead.
Change-Id: I8ef199463d46303129a3f563fd9eace780a58b8a
Signed-off-by: Frank Lichtenheld <fr...@lichtenheld.com>
---
M src/openvpn/socket.c
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/90/490/1
diff --git a/src/openvpn/socket.c b/src/openvpn/socket.c
index 480f4e5..c158de1 100644
--- a/src/openvpn/socket.c
+++ b/src/openvpn/socket.c
@@ -2031,7 +2031,10 @@
false);
if (!socket_defined(sock->sd))
{
- register_signal(sig_info, SIGTERM, "socket-undefiled");
+ if (signal_received)
+ {
+ register_signal(sig_info, SIGTERM, "socket-undefined");
+ }
return;
}
tcp_connection_established(&sock->info.lsa->actual);
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/490?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I8ef199463d46303129a3f563fd9eace780a58b8a
Gerrit-Change-Number: 490
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
