Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/506?usp=email )
Change subject: Implement support for AEAD tag at the end ...................................................................... Patch Set 2: Code-Review+1 (6 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/506/comment/1c8aa1ad_cba5214d : PS2, Line 8: Maybe some motivation? http://gerrit.openvpn.net/c/openvpn/+/506/comment/3a5c437c_30f55a3a : PS2, Line 9: Change-Id: I00821d75342daf3f813b829812d648fe298bea81 Missing sign-off Patchset: PS2: Makes sense to me, but needs some cleanup File src/openvpn/ssl.h: http://gerrit.openvpn.net/c/openvpn/+/506/comment/b447119b_b157eadb : PS2, Line 110: /** Suport for the AEAD tag at the end a larger peer id and IV */ "a" -> "and" http://gerrit.openvpn.net/c/openvpn/+/506/comment/a84daf75_4a3a415b : PS2, Line 111: #define IV_PROTO_DATA_V3 (1<<10) This define seems unused in the current patch? File tests/unit_tests/openvpn/test_ssl.c: http://gerrit.openvpn.net/c/openvpn/+/506/comment/f618ebc3_e68399f8 : PS2, Line 269: /* This adds a few more methods that strictly necessary but this allows "that" -> "than"? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/506?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I00821d75342daf3f813b829812d648fe298bea81 Gerrit-Change-Number: 506 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Mon, 05 Feb 2024 11:46:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
