Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/446?usp=email )
Change subject: Turn dead list test code into unit test ...................................................................... Patch Set 4: (3 comments) File tests/unit_tests/openvpn/test_misc.c: http://gerrit.openvpn.net/c/openvpn/+/446/comment/7dac6168_d24ef656 : PS2, Line 203: ASSERT(hash_add(hash, w->word, w, false)); > Should probably use the cmocka assert_true here? Done http://gerrit.openvpn.net/c/openvpn/+/446/comment/e8916ca3_ce20ce1e : PS2, Line 261: ASSERT(count == hash_n_elements(hash)); > should use assert_int_equal Done http://gerrit.openvpn.net/c/openvpn/+/446/comment/1c366976_7d353c43 : PS2, Line 268: hash_remove_by_value(nhash, (void *) i); > can we test that this was successful? Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/446?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I7511bc43cd6a0bcb89476f27d5822ab4a78d0d21 Gerrit-Change-Number: 446 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Mon, 05 Feb 2024 13:43:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
