Acked-by: Gert Doering <g...@greenie.muc.de>
Stare-at-code looks good :-) - there's one possible catch should realloc()
return NULL - in that case we'd pass drv.ifd_data = NULL to the kernel - but
I'm reasonably sure the kernel will then not crash but return EINVAL.
I do not have a sufficient number of clients on a FreeBSD 14 system today
to trigger the original problem, but I can attest that the new dynamic
code will do the right thing - I tested this by reducing the start allocation
to 1 byte and see it grow to 1024 (test with 2 clients, 512 sufficient
for 1 client).
(Also, master+patch passes the full server test rig on FreeBSD 14)
Your patch has been applied to the master and release/2.6 branch (bugfix)
commit 62676935d738f74908845ca96819a36a8c0c230e (master)
commit d8faf568d237667c66141e2c3f6df3f999aa02bd (release/2.6)
Author: Kristof Provost
Date: Wed Jan 24 16:27:39 2024 +0100
dco-freebsd: dynamically re-allocate buffer if it's too small
Signed-off-by: Kristof Provost <kprov...@netgate.com>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20240124152739.28248-1-kprov...@netgate.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28128.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
