Hi Arne,
commit 70b39f2bea9fd6e57f31e32b2041246731140cb2 has added the use of
ACK_SIZE and RELIABLE_ACK_SIZE in test_ssl.c. These are defined in
reliable.h which should be included through your ssl.h. Since our ssl.h
is being picked up, these never get defined and make check results in
the following error:
test_ssl.c: In function ‘init_frame_parameters’:
test_ssl.c:160:17: warning: implicit declaration of function ‘ACK_SIZE’
[-Wimplicit-function-declaration]
160 | overhead += ACK_SIZE(RELIABLE_ACK_SIZE);
| ^~~~~~~~
test_ssl.c:160:26: error: ‘RELIABLE_ACK_SIZE’ undeclared (first use in
this function)
160 | overhead += ACK_SIZE(RELIABLE_ACK_SIZE);
| ^~~~~~~~~~~~~~~~~
Somehow, this has never come up as an issue.
Sincerely
Juliusz Sosinowicz
On 09/02/2024 21:50, Arne Schwabe wrote:
Am 09.02.24 um 16:51 schrieb Juliusz Sosinowicz:
Including "ssl.h" conflicts with the wolfSSL ssl.h header file. The
include/wolfssl directory is included before openvpn/src.
include/wolfssl needs to be included so that openvpn can pick up
wolfSSL compatibility headers instead of OpenSSL headers without
changing the paths.
Neither the ssl.h (2005, so forever) in OpenVPN nor the ssl.h in
wolfssl (2014 according to git blame) are particulary new. Why is this
now a problem when it was never before?
Arne
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
