On 19/02/2024 14:12, Gert Doering wrote:
Maybe that would be a more reasonable approach here... get rid of the
umbrella if(), and check individual bits inside.  It seems to be a
micro-optimization "skip this branch if we have no single feature active",
while at least MSSFIX is active by default.

Technically we still retain the "speed up" when all features are disabled (i.e. remove this and this from the config and gain some Mbps)

But I do agree that the code complexity is not worth the gain, for a very narrow corner case.

I vote for letting the umbrella if() go.


Antonio Quartulli

Openvpn-devel mailing list

Reply via email to