Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/523?usp=email )
Change subject: Http-proxy: fix bug preventing proxy credentials caching ...................................................................... Patch Set 5: (4 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/523/comment/0095e7d0_7032f979 : PS5, Line 21: http_proxy_options and also a getter method to retrieve The man page for --auth-nocache still says it has no effect on --http-proxy. This needs to be updated. File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/523/comment/10c5ad5e_1e39dee3 : PS5, Line 3126: if (ce->http_proxy_options) This needs to be moved one level up. E.g. when using "--proto tcp4-client" currently --auth-nocache is ignored, since proto is already PROTO_TCP_CLIENT. There should be no issue with always setting this independently of ce->proto. File src/openvpn/proxy.h: http://gerrit.openvpn.net/c/openvpn/+/523/comment/2c3993c2_e1173cce : PS5, Line 61: bool nocache; Please update "show_http_proxy_options" in options.c to show value of nocache. File src/openvpn/proxy.c: http://gerrit.openvpn.net/c/openvpn/+/523/comment/663d790d_11843add : PS5, Line 669: if (p->up.nocache) wouldn't it be better to move this clearing into get_user_pass_http? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/523?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a Gerrit-Change-Number: 523 Gerrit-PatchSet: 5 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Comment-Date: Mon, 11 Mar 2024 14:45:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
