Attention is currently required from: plaisthos, reynir. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/555?usp=email )
Change subject: Only schedule_exit() once ...................................................................... Patch Set 1: (2 comments) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/555/comment/832e9f3f_055cb4bc : PS1, Line 525: return; You might want to consider changing the function to return a boolean to indicate whether it did anything. `send_auth_failure` already does the same check and could just use this one instead. And the other callers might also benefit from not doing other actions if exit is already scheduled. http://gerrit.openvpn.net/c/openvpn/+/555/comment/73f172e8_be13b424 : PS1, Line 530: event_timeout_init(&c->c2.scheduled_exit, n_seconds, now); > I have only now thought of it: what if the new `n_seconds` is sooner than the > already scheduled exit […] It is always `c->options.scheduled_exit_interval` which is always 5 at the moment. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/555?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9457f005f4ba970502e6b667d9dc4299a588d661 Gerrit-Change-Number: 555 Gerrit-PatchSet: 1 Gerrit-Owner: reynir <rey...@reynir.dk> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: reynir <rey...@reynir.dk> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: reynir <rey...@reynir.dk> Gerrit-Comment-Date: Mon, 22 Apr 2024 11:46:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: reynir <rey...@reynir.dk> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
