Attention is currently required from: flichtenheld, reynir.

plaisthos has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/555?usp=email )

Change subject: Only schedule_exit() once
......................................................................


Patch Set 3:

(1 comment)

File src/openvpn/forward.c:

http://gerrit.openvpn.net/c/openvpn/+/555/comment/e98ba825_8fe5fe4e :
PS1, Line 529:     reset_coarse_timers(c);
> I am not sure what the above three function calls do and if we should still 
> call them.
reset_coarse_timers ensures that newly scheduled timer actually is taken into 
account. `update_time` updates now for that. And  tls_set_single_session in 
typical OpenVPN fashion ensure that no renegotion can happy by using a 
completely different feature of setting the session into a mode where no 
renegotiation can happen.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/555?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9457f005f4ba970502e6b667d9dc4299a588d661
Gerrit-Change-Number: 555
Gerrit-PatchSet: 3
Gerrit-Owner: reynir <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-Reviewer: reynir <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Attention: reynir <[email protected]>
Gerrit-Comment-Date: Thu, 16 May 2024 11:12:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: reynir <[email protected]>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to