Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/662?usp=email )
Change subject: Lay the foundation to support both old and new versions of DCO ...................................................................... Patch Set 1: Code-Review-1 (4 comments) Patchset: PS1: A few small nitpicks File src/openvpn/dco_linux.h: http://gerrit.openvpn.net/c/openvpn/+/662/comment/23d9dd04_2e8af958 : PS1, Line 129: * @param nl_msg the message to use "The" http://gerrit.openvpn.net/c/openvpn/+/662/comment/e8c66910_d887f4a2 : PS1, Line 174: * extended in the future if we need to lookup more than one mcast id. "can be extended" ? File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/662/comment/7b654a13_31b82c62 : PS1, Line 1233: int cmd_del_peer = OVPN_CMD_DEL_PEER; Why is this indirection required? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/662?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6662605b60d4859949970cfe256c55cbcbd4a672 Gerrit-Change-Number: 662 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Comment-Date: Wed, 26 Jun 2024 16:58:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
