Attention is currently required from: mattock, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/669?usp=email )
Change subject: t_server_null: multiple improvements and fixes
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
So this works on FreeBSD and OpenBSD (great), while on NetBSD it works
*sometimes*, and then it fails to start servers again because the old servers
are still running.
When it does not work, the error message could use some improvement
```
make check-TESTS
./t_server_null.sh: sudo /bin/kill -0 succeeded, good.
OpenVPN test servers up: 0/ 2
OpenVPN test servers up: 0/ 2
OpenVPN test servers up: 0/ 2
OpenVPN test servers up: 0/ 2
OpenVPN test servers up: 0/ 2
OpenVPN test servers up: 0/ 2
All clients have disconnected from all servers
Waiting for servers to exit
cat: ./t_server_null_server-1194_udp.pid: No such file or directory
Terminated
[1] Terminated ("${@}" 2>&1; es... | tee -a "${log_fi...
```
(like, showing a "tail -f" of the server logs? - which are root-owned and mode
0600, so not trivial. Why are they 0600 anyway, is there an explicit umask
call?)
Not sure why the processes got stuck. When running from the CLI the servers
are properly terminated... need to re-test from buildbot.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/669?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2cce8ad4e0d262e1404ab1eb6ff673d8590b6b3a
Gerrit-Change-Number: 669
Gerrit-PatchSet: 4
Gerrit-Owner: mattock <sam...@openvpn.net>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: cron2 <g...@greenie.muc.de>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: mattock <sam...@openvpn.net>
Gerrit-Comment-Date: Wed, 03 Jul 2024 14:13:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
