Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/672?usp=email )
Change subject: Allow trailing \r and \n in control channel message ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Patchset: PS2: I must say that I would feel better if we had a UT covering all this. Not sure how difficult that would be? File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/672/comment/9a73fe6c_d79f0ee2 : PS2, Line 318: format_hex(BPTR(&buf), BLEN(&cmdbuf), 256, &gc)); While it is not actually wrong to use BPTR(&buf) here, I would recommend BPTR(&cmdbuf). It should make no difference to the output and looks less like an error. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/672?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I47c992b6b73b1475cbff8a28f720cf50dc1fbe3e Gerrit-Change-Number: 672 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Mon, 08 Jul 2024 16:32:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
