пн, 8 июл. 2024 г. в 23:47, Antonio Quartulli <a...@unstable.cc>: > > Hi, > > On 08/07/2024 23:44, Илья Шипицин wrote: > >>> + msg( M_FATAL, "Failed allocate memory > >>> saved_pid_file_name"); > >> > >> patchset looks great, but (!!) there should be no space after the > >> opening parenthesis.. > > > > I just followed code style already present in repo > > > > $ grep -r 'msg( M_FATAL' . > > grep: > > ./.git/objects/pack/pack-d09f3eabac42224b1dc52ffb4f53d9af23bc5b7d.pack: > > binary file matches > > ./src/openvpn/auth_token.c: msg( M_FATAL, "Failed to get enough > > randomness for " > > ./src/openvpn/tun.c: msg( M_FATAL, "init_tun: problem > > converting IPv6 ifconfig addresses %s and %s to binary", > > ifconfig_ipv6_local_parm, ifconfig_ipv6_remote_parm ); > > ./src/openvpn/tun.c: msg( M_FATAL, "cannot find unused tap > > device" ); > > ./src/openvpn/tun.c: msg( M_FATAL, "TAP device name must be > > '--dev tapNNNN'" ); > > Unfortunately those are unlucky leftovers that haven't been fixed yet: > > $ grep -r 'msg(M_FATAL' . |wc -l > 286 > > $ grep -r 'msg( M_FATAL' . |wc -l > 4 > > > > > also, uncrustify GHA jobs agreed that it is no formatting violation > > doubly unfortunate as I think uncrustify can't force this or it gets > confused somehow :(
if those spaces makes you unhappy, I'm fine if you fix them during commit apply > > > Cheers, > > > > -- > Antonio Quartulli _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
