Attention is currently required from: plaisthos, selvanair. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/665?usp=email )
Change subject: Static-challenge concatenation option ...................................................................... Patch Set 2: Code-Review-1 (2 comments) File doc/management-notes.txt: http://gerrit.openvpn.net/c/openvpn/+/665/comment/bf183267_3d352506 : PS2, Line 1333: FORMAT = bit 2 = 1 if response should be concatenated with password Honestly it is not clear to me from this documentation on how these flags combine. Concatenate them? Binary addition? Please include an example. File src/openvpn/misc.h: http://gerrit.openvpn.net/c/openvpn/+/665/comment/49006d0b_8f0cea84 : PS2, Line 121: #define GET_USER_PASS_STATIC_CHALLENGE_CONCAT (1<<11) /* indicates password and response should be concatenated */ Please add a test to the UT suite test_get_user_pass_static_challenge -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/665?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I59a90446bfe73d8856516025a58a6f62cc98ab0d Gerrit-Change-Number: 665 Gerrit-PatchSet: 2 Gerrit-Owner: selvanair <selva.n...@gmail.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: selvanair <selva.n...@gmail.com> Gerrit-Comment-Date: Tue, 09 Jul 2024 12:57:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
