On Wed, Jul 10, 2024 at 09:32:39PM +0200, Gert Doering wrote:
> Hi,
> 
> On Wed, Jul 10, 2024 at 06:03:06PM +0200, Frank Lichtenheld wrote:
> > Mostly so we can use anonymous structs without jumping through
> > hoops or relying on unofficial support.
> > 
> > Change-Id: I72934e747d1ad68a7e3675afbeb1b63df7941186
> > Signed-off-by: Frank Lichtenheld <fr...@lichtenheld.com>
> > Acked-by: Arne Schwabe <arne-open...@rfc2549.org>
> > ---
> > 
> > This change was reviewed on Gerrit and approved by at least one
> > developer. I request to merge it to master.
> 
> This breaks all OpenBSD 6.8 builds.  Are you intentionally ignoring
> this ("this OS is out of support, we'll discontinue this buildbot"?  If
> yes, we might want to point out that this change has fallout on older
> "build environments" - not sure what is problematic here, C compiler or
> system headers, or libc...

Yes, ignoring that intentionally. I plan to disable OpenBSD 6.8 builds for 
master
instead.

Basically the intent of this patch is to approve
https://gerrit.openvpn.net/c/openvpn/+/588 (Remove check for anonymous unions
from configure and cmake config) but improve it by officially switching to C11
(which implies support for anonymous unions).

We can certainly extend the messaging.

Regards,
-- 
  Frank Lichtenheld


_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to