Attention is currently required from: plaisthos, selvanair. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/730?usp=email )
Change subject: Add a test for loading certificate and key using file: URI ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File tests/unit_tests/openvpn/test_ssl.c: http://gerrit.openvpn.net/c/openvpn/+/730/comment/efb80c80_18698be7 : PS1, Line 249: #endif /* HAVE_OPENSSL_STORE */ I would prefer to use #else here so that there is no dead code. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/730?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I7615116b5251319aa1f13d671bab7013f3a043ea Gerrit-Change-Number: 730 Gerrit-PatchSet: 1 Gerrit-Owner: selvanair <selva.n...@gmail.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: selvanair <selva.n...@gmail.com> Gerrit-Comment-Date: Thu, 05 Sep 2024 10:01:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel