Attention is currently required from: plaisthos. ralf_lici has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/737?usp=email )
Change subject: Fix check_addr_clash argument order ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Code change makes sense to me, but I haven' tested it. […] If you simply want to evaluate if the order is coherent between the arguments you can enable the debugging code at the beginning of check_addr_clash(). To actually trigger the tun warning I created a tuntap interface (tun0) and set the ip address to 10.10.20.1/24. Then I executed: openvpn --ifconfig 10.10.20.10 255.255.255.0 --local 10.10.20.1 --dev tun0 --topology subnet ... The tap warning can be triggered by executing: openvpn --ifconfig 10.10.20.10 255.255.255.0 --local 10.10.20.1 --dev tap ... Nevertheless I could not find a way to trigger the first warning in check_addr_clash() (line 564) because I think a previous check already ensures that --local or --remote addresses are not the same as the --ifconfig addresses (but I'm not entirely sure if this is always the case). -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/737?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I5adbe0a79f078221c4bb5f3d39391a81b4d8adce Gerrit-Change-Number: 737 Gerrit-PatchSet: 1 Gerrit-Owner: ralf_lici <r...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Wed, 11 Sep 2024 16:53:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
