Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/724?usp=email )
Change subject: configure: Handle libnl-genl and libcap-ng consistent with
other libs
......................................................................
Patch Set 3: Code-Review-1
(3 comments)
Patchset:
PS3:
Feature-ACK, but it does not work for me.
I applied this against 14d2db6cd41fb6 on Ubuntu 20.04, did `autoreconf -vif`
then `configure`, `make`, and it fails for me with
```
gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../../include
-I../../src/compat -I/usr/include/lzo
-DPLUGIN_LIBDIR=\"/usr/local/lib/openvpn/plugins\" -Wall
-Wno-stringop-truncation -g -O2 -std=c11 -MT options.o -MD -MP -MF $depbase.Tpo
-c -o options.o options.c &&\
mv -f $depbase.Tpo $depbase.Po
In file included from dco_internal.h:31,
from dco.h:31,
from tun.h:43,
from socket.h:37,
from ssl.h:38,
from options.c:45:
dco_linux.h:31:10: fatal error: netlink/socket.h: No such file or directory
31 | #include <netlink/socket.h>
| ^~~~~~~~~~~~~~~~~~
compilation terminated.
```
because the LIBNL_GENL_CFLAGS do not show up on the gcc command line...
File configure.ac:
http://gerrit.openvpn.net/c/openvpn/+/724/comment/546e2b93_7afac6b6 :
PS3, Line 1495: AC_SUBST([OPTIONAL_LIBNL_GENL_LIBS])
so what are these needed for? I see that the generated `src/openvpn/Makefile`
has both
```
LIBNL_GENL_CFLAGS = -I/usr/include/libnl3
LIBNL_GENL_LIBS = -lnl-genl-3 -lnl-3
```
and
```
OPTIONAL_LIBNL_GENL_CFLAGS = -I/usr/include/libnl3
OPTIONAL_LIBNL_GENL_LIBS = -lnl-genl-3 -lnl-3
```
so this seems slightly redundant...
http://gerrit.openvpn.net/c/openvpn/+/724/comment/97ee1a30_d7a7fbe2 :
PS3, Line 1545: TEST_CFLAGS="${TEST_CFLAGS} -I\$(top_srcdir)/include
${CMOCKA_CFLAGS}"
This is `TEST_*` only, but shouldn't we have these for `AM_CFLAGS` and
`openvpn_LDADD` as well?
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/724?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I39a6f58b11b922f5dbd3e55a5bc8574eda8a83fe
Gerrit-Change-Number: 724
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Tue, 17 Sep 2024 13:12:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
