Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/751?usp=email )

Change subject: Add building/testing with msbuild and the clang compiler
......................................................................


Patch Set 4:

(2 comments)

File CMakePresets.json:

http://gerrit.openvpn.net/c/openvpn/+/751/comment/b0c7528e_5a22270e :
PS4, Line 145: arm64
> Why no support for ARM64?
iirc when I did try for OpenVPN3, arm64 support was not included with clang 
toolset in msvc, will check again. But it seems that it is not supported:

error: in triplet arm64-windows-ovpn: Unable to find a valid toolchain for 
requested target architecture arm64.
The selected Visual Studio instance is at: C:\Program Files\Microsoft Visual 
Studio\2022\Community
The available toolchain combinations are: x86, amd64, x86_amd64, amd64_x86


File src/openvpnmsica/openvpnmsica.h:

http://gerrit.openvpn.net/c/openvpn/+/751/comment/f8f306e1_5157f7ed :
PS4, Line 69: /* Ensure that clang-cl, which does not understand the #pragma 
comment(linker, ...)
> That comment seems more suited to the changes to openvpnmsica. […]
yeah will reword that.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/751?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I43d84034f3e920a45731c4aab4f851a60921290d
Gerrit-Change-Number: 751
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Wed, 18 Sep 2024 11:32:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to