Attention is currently required from: flichtenheld, its_Giaan, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/757?usp=email )
Change subject: event/multi: add event_arg object to make event handling more generic ...................................................................... Patch Set 1: (5 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/757/comment/aa46d7bd_e7e189df : PS1, Line 11: distinguish which of these sockets have been pocked by an incoming > poked? Acknowledged http://gerrit.openvpn.net/c/openvpn/+/757/comment/adc64174_bd2c6985 : PS1, Line 15: event handler argument, from a "partly integer evaluated variable" > "integer-evaluated" would be easier to parse I think. Acknowledged http://gerrit.openvpn.net/c/openvpn/+/757/comment/7946288e_fc23bcb7 : PS1, Line 22: use only one socket to handle all clients i/o. > Sounds clunky, "I/O of all clients" maybe? Or just "all clients. […] 'all clients' sounds good File src/openvpn/multi.h: http://gerrit.openvpn.net/c/openvpn/+/757/comment/a9e5c953_3086edb7 : PS1, Line 105: struct event_arg ev_arg; > Please add documentation […] With the current approach we pass &mi as data to the event engine, because if data is an address we know for sure that it must be a mi. Now we want to put ourselves in the position to pass either a multi_instance or a link_socket object. For this reason we can't simply pass their address as we would not have a way to understand what object that is. Therefore the idea is to use a new struct (ev_arg) which internally will give me the pointer of the mi or ls, depending on the event type. Since we need this new struct to live somewhere, it was easier to locate it within the same struct that it points to (hence link_socket and multi_instance). To some extends, you may take it as a "event base class", which is then interpreted as mi or ls. Does it help understanding what is going on? File src/openvpn/socket.h: http://gerrit.openvpn.net/c/openvpn/+/757/comment/b8214964_f33cc340 : PS1, Line 169: struct event_arg ev_arg; > Please add documentation explained in previous reply. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/757?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Icd7f6a2ad350cdc2312b3e80fa0dbdd7e4311d2e Gerrit-Change-Number: 757 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: ordex <a...@unstable.cc> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Wed, 25 Sep 2024 11:47:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
