Attention is currently required from: flichtenheld, ordex, plaisthos.

its_Giaan has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/759?usp=email )

Change subject: io_work: convert shift argument to uintptr_t
......................................................................


Patch Set 2:

(3 comments)

File src/openvpn/forward.c:

http://gerrit.openvpn.net/c/openvpn/+/759/comment/54e37e09_433ffd78 :
PS1, Line 2054:     static uintptr_t socket_shift = 0;   /* depends on 
SOCKET_READ and SOCKET_WRITE */
> I think this patch predates the introduction of those macros. […]
Done


http://gerrit.openvpn.net/c/openvpn/+/759/comment/5b145b31_80e33bef :
PS1, Line 2171:
> the & should not be there.
Done


http://gerrit.openvpn.net/c/openvpn/+/759/comment/d6e4081a_007cb7b8 :
PS1, Line 2176: dco_shift
> the & should not be there
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/759?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib583bf17e35b14aed78fd8217b6e71e8c2b78089
Gerrit-Change-Number: 759
Gerrit-PatchSet: 2
Gerrit-Owner: its_Giaan <gianma...@mandelbit.com>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-CC: ordex <a...@unstable.cc>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: ordex <a...@unstable.cc>
Gerrit-Comment-Date: Tue, 01 Oct 2024 15:31:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com>
Comment-In-Reply-To: ordex <a...@unstable.cc>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to