Tested on the server testbed, which has all the relevant operations here -
UDP/TCP client, UDP/TCP servers, ... - all works fine.

The code change itself touches many places, but is actually quite 
straightforward here - "c->c2.link_socket->..." gets replaced by
"sock->...", with "sock" passed in as "c->c2.link_socket" (as of now).

.. making many of these functions easier to read, which is nice ;-)

(On the renaming of "struct link_socket *ls" to "... *sock" bit, I should
have paid more attention earlier in the review process - this is basically
an fairly large and unrelated change which makes the code different
to 2.6, for no really good reason - maybe keeping the original patch
with "struct link_socket *ls" everywhere else would have been nicer, as
it's more than "just a socket" anyway)

Your patch has been applied to the master branch.

commit 490d1324c87446b48462da18cfde1b755c9883e8
Author: Antonio Quartulli
Date:   Wed Oct 23 10:34:44 2024 +0200

     pass link_socket object to i/o functions

     Signed-off-by: Antonio Quartulli <[email protected]>
     Signed-off-by: Gianmarco De Gregori <[email protected]>
     Acked-by: Frank Lichtenheld <[email protected]>
     Message-Id: <[email protected]>
     URL: 
https://www.mail-archive.com/[email protected]/msg29603.html
     Signed-off-by: Gert Doering <[email protected]>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to