Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/817?usp=email
to review the following change.
Change subject: Add small unit test for buf_chomp
......................................................................
Add small unit test for buf_chomp
Change-Id: Ia0799189d45223e0b987a5a4da5be60404388f1f
Signed-off-by: Arne Schwabe <[email protected]>
---
M tests/unit_tests/openvpn/test_buffer.c
1 file changed, 28 insertions(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/17/817/1
diff --git a/tests/unit_tests/openvpn/test_buffer.c
b/tests/unit_tests/openvpn/test_buffer.c
index 0fb4697..d43d5c1 100644
--- a/tests/unit_tests/openvpn/test_buffer.c
+++ b/tests/unit_tests/openvpn/test_buffer.c
@@ -426,6 +426,32 @@
#endif
}
+void
+test_buffer_chomp(void **state)
+{
+ struct gc_arena gc = gc_new();
+ struct buffer buf = alloc_buf_gc(1024, &gc);
+
+ const char test1[] = "There is a nice 1234 year old tree!\n\r";
+ buf_write(&buf, test1, sizeof(test1));
+ buf_chomp(&buf);
+ /* Check that our own method agrees */
+ assert_true(string_check_buf(&buf, CC_PRINT | CC_NULL, CC_CRLF));
+ assert_string_equal(BSTR(&buf), "There is a nice 1234 year old tree!");
+
+ struct buffer buf2 = alloc_buf_gc(1024, &gc);
+ const char test2[] = "CR_RESPONSE,MTIx\x0a\x00";
+ buf_write(&buf2, test2, sizeof(test2));
+ buf_chomp(&buf2);
+
+ buf_chomp(&buf2);
+ /* Check that our own method agrees */
+ assert_true(string_check_buf(&buf2, CC_PRINT | CC_NULL, CC_CRLF));
+ assert_string_equal(BSTR(&buf2), "CR_RESPONSE,MTIx");
+
+ gc_free(&gc);
+}
+
int
main(void)
{
@@ -460,7 +486,8 @@
cmocka_unit_test(test_buffer_gc_realloc),
cmocka_unit_test(test_character_class),
cmocka_unit_test(test_character_string_mod_buf),
- cmocka_unit_test(test_snprintf)
+ cmocka_unit_test(test_snprintf),
+ cmocka_unit_test(test_buffer_chomp)
};
return cmocka_run_group_tests_name("buffer", tests, NULL, NULL);
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/817?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia0799189d45223e0b987a5a4da5be60404388f1f
Gerrit-Change-Number: 817
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
