On Tuesday, November 26th, 2024 at 8:32 AM, Gert Doering <g...@greenie.muc.de> 
wrote:
> 

> this is great, but alas...
> On Tue, Nov 26, 2024 at 02:26:52PM +0000, Alexander von Gluck via 
> Openvpn-devel wrote:
> 

> > +#el
> > if defined(TARGET_HAIKU)
> 

> ...
> 

> > +#if defined(TARGET_H
> > AIKU)
>
> ... your mail program is wrapping the lines in weird ways.
> 

> Can you please send with git-send-email or push to our gerrit?

Weird, yeah.  I'm using git-send-email but through a proton mail bridge. Sorry 
for the noise.
 

> (https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation#PatchsubmissionviaGerrit)

I'll submit via Gerrit with your recommendations.


> > + // Need to add ifconfig_remote_netmask since right now it is just NULL
> ... and while at it: no // comments, please.

Will fix this (and other review comments)

Thanks!

 -- Alex

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to