Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/821?usp=email
to review the following change.
Change subject: Fix some formatting related to if/else and macros
......................................................................
Fix some formatting related to if/else and macros
Make it clearer where the blocks are.
Change-Id: If645c3faf149bac82167a91be13541b30a1b8d6a
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/helper.c
M src/openvpn/manage.c
M src/openvpn/openvpn.c
3 files changed, 13 insertions(+), 9 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/21/821/1
diff --git a/src/openvpn/helper.c b/src/openvpn/helper.c
index bbdbc04..9e28e87 100644
--- a/src/openvpn/helper.c
+++ b/src/openvpn/helper.c
@@ -500,7 +500,7 @@
push_option(o, print_opt_route_gateway_dhcp(&o->gc), M_USAGE);
}
}
- else
+
/*
* HELPER DIRECTIVE:
*
@@ -511,7 +511,7 @@
* pull
* tls-client
*/
- if (o->client)
+ else if (o->client)
{
o->pull = true;
o->tls_client = true;
diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c
index f296788..e79a118 100644
--- a/src/openvpn/manage.c
+++ b/src/openvpn/manage.c
@@ -1822,7 +1822,9 @@
}
else
#endif
- man->connection.sd_cli = socket_do_accept(man->connection.sd_top, &act,
false);
+ {
+ man->connection.sd_cli = socket_do_accept(man->connection.sd_top,
&act, false);
+ }
if (socket_defined(man->connection.sd_cli))
{
@@ -1971,9 +1973,11 @@
}
else
#endif
- msg(D_LINK_ERRORS | M_ERRNO,
- "MANAGEMENT: connect to %s failed",
- print_sockaddr(man->settings.local->ai_addr, &gc));
+ {
+ msg(D_LINK_ERRORS | M_ERRNO,
+ "MANAGEMENT: connect to %s failed",
+ print_sockaddr(man->settings.local->ai_addr, &gc));
+ }
throw_signal_soft(SIGTERM, "management-connect-failed");
goto done;
}
diff --git a/src/openvpn/openvpn.c b/src/openvpn/openvpn.c
index 1db5422..c52540c 100644
--- a/src/openvpn/openvpn.c
+++ b/src/openvpn/openvpn.c
@@ -274,10 +274,10 @@
/* Query passwords before becoming a daemon if we don't use the
* management interface to get them. */
-#ifdef ENABLE_MANAGEMENT
if (!(c.options.management_flags & MF_QUERY_PASSWORDS))
-#endif
- init_query_passwords(&c);
+ {
+ init_query_passwords(&c);
+ }
/* become a daemon if --daemon */
if (c.first_time)
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/821?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If645c3faf149bac82167a91be13541b30a1b8d6a
Gerrit-Change-Number: 821
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
