Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/801?usp=email )
Change subject: Change API of init_key_ctx to use struct key_paramters ...................................................................... Patch Set 5: (6 comments) Patchset: PS5: thanks for the review File src/openvpn/crypto.h: http://gerrit.openvpn.net/c/openvpn/+/801/comment/8d53de3a_4d1c5e54 : PS5, Line 158: /** internal structure similar to struct key that hold key information > "holds" Done File src/openvpn/crypto.c: http://gerrit.openvpn.net/c/openvpn/+/801/comment/ce856d23_fcfbd114 : PS5, Line 902: , > Needs update Done http://gerrit.openvpn.net/c/openvpn/+/801/comment/a387265a_62cbf33e : PS5, Line 915: impl_iv_len > Change to `ASSERT(impl_iv_len <= key->hmac_size);` to keep consistency Done http://gerrit.openvpn.net/c/openvpn/+/801/comment/0fbf3998_33a8a7fa : PS5, Line 1128: key_params->cipher_size = MAX_HMAC_KEY_LENGTH; > `MAX_CIPHER_KEY_LENGTH` Acknowledged http://gerrit.openvpn.net/c/openvpn/+/801/comment/e070181c_273bb98a : PS5, Line 1129: MAX_CIPHER_KEY_LENGTH > `MAX_HMAC_KEY_LENGTH` Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/801?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4a981c5a70717e2276d89bf83a06c7fdbe6712d7 Gerrit-Change-Number: 801 Gerrit-PatchSet: 5 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Sat, 30 Nov 2024 12:41:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
