Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/826?usp=email
to review the following change.
Change subject: Fix memory leak in ntlm_support
......................................................................
Fix memory leak in ntlm_support
Not really important but prevents running the NTLM
t_client tests with ASAN enabled.
Change-Id: If472398d4ff8323de485f084a07160b365dfc501
Signed-off-by: Frank Lichtenheld <fr...@lichtenheld.com>
---
M tests/ntlm_support.c
1 file changed, 8 insertions(+), 4 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/26/826/1
diff --git a/tests/ntlm_support.c b/tests/ntlm_support.c
index ccf8962..18d555a 100644
--- a/tests/ntlm_support.c
+++ b/tests/ntlm_support.c
@@ -33,11 +33,11 @@
int
main(void)
{
-#if defined(ENABLE_CRYPTO_OPENSSL)
- crypto_load_provider("legacy");
- crypto_load_provider("default");
-#endif
#ifdef NTLM
+#if defined(ENABLE_CRYPTO_OPENSSL)
+ provider_t *legacy = crypto_load_provider("legacy");
+ provider_t *def = crypto_load_provider("default");
+#endif
if (!md_valid("MD4"))
{
msg(M_FATAL, "MD4 not supported");
@@ -46,6 +46,10 @@
{
msg(M_FATAL, "MD5 not supported");
}
+#if defined(ENABLE_CRYPTO_OPENSSL)
+ crypto_unload_provider("legacy", legacy);
+ crypto_unload_provider("default", def);
+#endif
#else /* ifdef NTLM */
msg(M_FATAL, "NTLM support not compiled in");
#endif
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/826?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If472398d4ff8323de485f084a07160b365dfc501
Gerrit-Change-Number: 826
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
