Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/828?usp=email )
Change subject: Allow DEFAULT in data-ciphers and report both expanded and user set option ...................................................................... Patch Set 1: Code-Review-1 (6 comments) Patchset: PS1: Some nitpicks File doc/man-sections/protocol-options.rst: http://gerrit.openvpn.net/c/openvpn/+/828/comment/5f75330f_045154c7 : PS1, Line 181: Starting with OpenVPN 2.7 the special keyword DEFAULT can be used in the Probably makes sense to use ``DEFAULT`` here. File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/828/comment/9501c1ac_eab351db : PS1, Line 1905: "Server data-ciphers: '%s'%s, client supports cipher '%s'", make consistent with the other case. Either '%s%s' or '%s'%s, but not both. File src/openvpn/ssl_ncp.h: http://gerrit.openvpn.net/c/openvpn/+/828/comment/1d04131f_fb1c7b2c : PS1, Line 174: * The returned string will be allocated in the passed \param gc If you want to format a word as param use \p, \param is for documenting parameters. File src/openvpn/ssl_ncp.c: http://gerrit.openvpn.net/c/openvpn/+/828/comment/c25085e2_a57ade0c : PS1, Line 537: * Replaces the string DEFAULT with the string \param replace. The \p File tests/unit_tests/openvpn/test_ncp.c: http://gerrit.openvpn.net/c/openvpn/+/828/comment/87f080cb_fef0e6b6 : PS1, Line 356: test_ncp_expand(void **state) I would suggest to add a testcase here where ncp_cipher_conf contains DEFAULT but is not equal to DEFAULT. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/828?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia1c5209022d3ab4c0dac6438c41891c7d059f812 Gerrit-Change-Number: 828 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Tue, 10 Dec 2024 17:35:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
