Attention is currently required from: d12fk, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/836?usp=email )
Change subject: service: add utf8to16 function that takes a size ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: Breaks GHA MinGW builds for me :-( https://github.com/cron2/openvpn/actions/runs/12438329894/job/34730024149 ``` /usr/bin/i686-w64-mingw32-ld: src/openvpnserv/CMakeFiles/openvpnserv.dir/Debug/interactive.c.obj: in function `InterfaceLuid': 2474 /home/runner/work/openvpn/openvpn/src/openvpnserv/interactive.c:554: undefined reference to `utf8to16' 2475 /usr/bin/i686-w64-mingw32-ld: src/openvpnserv/CMakeFiles/openvpnserv.dir/Debug/interactive.c.obj: in function `SetDNSDomain': 2476 /home/runner/work/openvpn/openvpn/src/openvpnserv/interactive.c:1242: undefined reference to `utf8to16' 2477 /usr/bin/i686-w64-mingw32-ld: src/openvpnserv/CMakeFiles/openvpnserv.dir/Debug/interactive.c.obj: in function `HandleDNSConfigMessage': 2478 /home/runner/work/openvpn/openvpn/src/openvpnserv/interactive.c:1297: undefined reference to `utf8to16' 2479 /usr/bin/i686-w64-mingw32-ld: src/openvpnserv/CMakeFiles/openvpnserv.dir/Debug/interactive.c.obj: in function `HandleWINSConfigMessage': 2480 /home/runner/work/openvpn/openvpn/src/openvpnserv/interactive.c:1394: undefined reference to `utf8to16' ``` so it seems the macro definition is not included "in the right places". Does this need another patch to be applied as prerequisite? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/836?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6b4aa3d63c0b684bf95841271c04bc5d9c37793b Gerrit-Change-Number: 836 Gerrit-PatchSet: 1 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: d12fk <he...@openvpn.net> Gerrit-Comment-Date: Fri, 20 Dec 2024 21:07:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
