Attention is currently required from: flichtenheld, plaisthos.

cron2 has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/800?usp=email )

Change subject: Move initialisation of implicit IVs to init_key_ctx_bi methods
......................................................................


Patch Set 8: Code-Review+2

(1 comment)

Patchset:

PS8:
Looks good. It's a bit more complex than "just move 
`key_ctx_update_implicit_iv()` around, as the calling convention changes and 
not all current callers of `init_key_ctx_bi()` are calling it afterwards - but 
these are all non-AEAD cases, so the function will not do anything in these 
cases.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/800?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id223612c7bcab91d49c013fb775024bd64ab0836
Gerrit-Change-Number: 800
Gerrit-PatchSet: 8
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Sun, 22 Dec 2024 21:45:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to