Acked-by: Gert Doering <g...@greenie.muc.de>

This is a nice min-feature, to improve on IPv6 support in OpenVPN - thanks.

I have stared at the code ("looks reasonable") and then actually set up
a port-share test setup, with a v6-only lighttpd behind an OpenVPN port-share,
and "it just works"

    Dec 25 16:59:53 TCP connection established with 
[AF_INET6]2001:608:4::ce:c0f:54067
    Dec 25 16:59:53 TCPv6_SERVER link remote: [AF_INET6]2001:608:4::ce:c0f:54067
    Dec 25 16:59:53 2001:608:4::ce:c0f Non-OpenVPN client protocol detected

.. it doesn't show the target here, but the connection arrives, and is
also documented properly in the "[dir]"

# ls -l
-rw-r----- 1 root root   34 Dec 25 17:00 '[AF_INET6]::1:33956'
# cat *
[AF_INET6]2001:608:4::ce:c0f:54067

(the [AF_INET6] blob looks a bit confusing, but I guess this is the
way it has always been for the port-share status files - port numbers are
ugly as well, but indeed, this is a long-standing itch in our printing
routines)

I have adjusted From: and Signed-Off-By: of this patch to match the
later "v2" patches in the other series - full names are important for
us for correct attribution.

Your patch has been applied to the master branch.

commit 993449a3b6c0ae57c47844c9c19ea54633cbd914
Author: Corubba Smith
Date:   Sat Dec 14 20:56:56 2024 +0100

     Support IPv6 towards port-share proxy receiver

     Signed-off-by: Corubba Smith <coru...@gmx.de>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <dcc7e538-2035-4697-b306-10eb47063...@gmx.de>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30115.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to