Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/801?usp=email )
Change subject: Change API of init_key_ctx to use struct key_parameters ...................................................................... Patch Set 9: Code-Review+2 (6 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/801/comment/b730dde1_23369276 : PS8, Line 7: Change API of init_key_ctx to use struct key_paramters > key_parameters Done http://gerrit.openvpn.net/c/openvpn/+/801/comment/38a47023_5a01c0b0 : PS8, Line 9: This introduces a new structure key_paramters. The reason is that the > key_parameters Done File src/openvpn/crypto.h: http://gerrit.openvpn.net/c/openvpn/+/801/comment/a8cbf2dd_988a8316 : PS8, Line 176: * Converts a struct key representation into a struct key_params representation. > key_parameters Done File tests/unit_tests/openvpn/test_auth_token.c: http://gerrit.openvpn.net/c/openvpn/+/801/comment/a13bc939_51cc0c94 : PS8, Line 91: key.hmac_size = 64; /* 64 byte of 0 */ > Use `MAX_HMAC_KEY_LENGTH` instead? Done File tests/unit_tests/openvpn/test_tls_crypt.c: http://gerrit.openvpn.net/c/openvpn/+/801/comment/0f742488_2a2784c8 : PS8, Line 160: struct key_parameters key = { .cipher = { 0 }, .hmac = { 0 }, .hmac_size = 64, .cipher_size = 64 }; > Use `MAX_HMAC_KEY_LENGTH` and `MAX_CIPHER_KEY_LENGTH` instead? Done http://gerrit.openvpn.net/c/openvpn/+/801/comment/a43379bc_85313073 : PS8, Line 370: struct key_parameters key = { .cipher = { 1 }, .hmac = { 1 }, .cipher_size = 64, .hmac_size = 64 }; > Use `MAX_HMAC_KEY_LENGTH` and `MAX_CIPHER_KEY_LENGTH` instead? Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/801?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4a981c5a70717e2276d89bf83a06c7fdbe6712d7 Gerrit-Change-Number: 801 Gerrit-PatchSet: 9 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Fri, 27 Dec 2024 11:02:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
