Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/805?usp=email )
Change subject: Rename aead-tag-at-end to aead-epoch ...................................................................... Patch Set 8: Code-Review-1 (2 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/805/comment/2441bc09_930b0af9 : PS8, Line 8: maybe add a short explanation like: "We combine several data-format changes into one flag since they will be introduced together and so we do not need to separate them." File src/openvpn/crypto.h: http://gerrit.openvpn.net/c/openvpn/+/805/comment/7b1afc57_7cafb3b5 : PS8, Line 373: * AEAD tag is at the end of the packet and using epoch Remove "at", remove additional space before "packet". The sentence is still not great then, but at least superficially correct. Maybe simpler: "Bit-flag indicating that the AEAD tag is at the end of the packet and epoch keys are used" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/805?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9e9433b56dcbaa538d9bed30e50cf74948c647cc Gerrit-Change-Number: 805 Gerrit-PatchSet: 8 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Fri, 27 Dec 2024 15:46:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
