I'm not sure I understand all the intricacies here (like, "cipher_size = MAX_CIPHER_KEY_LENGTH", what's that for?), but it passes all the client/server test, memory operations look safe, and it has a unit test and a +2 from Frank :-)
Your patch has been applied to the master branch. commit 5bbf0aa484470486fcc2f491fba81605aa8649ed Author: Arne Schwabe Date: Fri Dec 27 12:11:33 2024 +0100 Change API of init_key_ctx to use struct key_parameters Signed-off-by: Arne Schwabe <a...@rfc2549.org> Acked-by: Frank Lichtenheld <fr...@lichtenheld.com> Message-Id: <20241227111133.5893-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30228.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel