Hi, I think the use of tchar is outdated and I'm all for purging it.
best, Selva On Wed, Jan 8, 2025 at 8:57 AM Frank Lichtenheld <fr...@lichtenheld.com> wrote: > Hi. > > Today I submitted a patch series that removes all usages of > tchar.h from the OpenVPN 2 code base. You can see the full > series here: https://gerrit.openvpn.net/q/topic:%22tchar-removal%22 > > This series came about when I looked into the Windows code > for a potential clang-format reformat and for reviewing > Heiko's DNS series. I learned about TEXT() and about how it > is basically useless in our case (since we never build > non-unicode builds anymore). I came to the conclusion that > this is somewhat inconsistently used, useless clutter, and > potential source for confusion. > > So I propose to remove the use of tchar.h and and associated > functions and just use wchar directly. The actual conversion > step is fully automated. See > https://gerrit.openvpn.net/c/openvpn/+/852 for the script. > So it can easily be rebased on any ongoing Windows work. > > Let me know what you guys think about it. CCing our Windows > experts. > > Regards, > -- > Frank Lichtenheld >
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
