This basically does not really add "system testable" code yet - but it does add unit tests (which pass), the code looks reasonable, and it comes with a +2 from MaxF in Gerrit.
A comment explaining what packet_id_send_update_epoch() is about would be nice, though... Your patch has been applied to the master branch. commit bc62a9a02cb7365a678bcd3f2faf537a420cc5a0 Author: Arne Schwabe Date: Thu Jan 9 18:55:28 2025 +0100 Add methods to read/write packet ids for epoch data Signed-off-by: Arne Schwabe <a...@rfc2549.org> Acked-by: MaxF <m...@max-fillinger.net> Message-Id: <20250109175528.22033-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30389.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel