Attention is currently required from: flichtenheld, plaisthos.

cron2 has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/855?usp=email )

Change subject: Improve error reporting from AF_UNIX tun/tap support
......................................................................


Patch Set 2: Code-Review-2

(1 comment)

Patchset:

PS2:
breaks windows builds (at least, mingw).

```
o/buildbot/ubuntu-2404-mingw/build/src/openvpn/run_command.c:117:20: error: 
implicit declaration of function ???waitpid??? 
[-Werror=implicit-function-declaration]
o/buildbot/ubuntu-2404-mingw/build/src/openvpn/run_command.c:117:42: error: 
???WNOHANG??? undeclared (first use in this function)
o/buildbot/ubuntu-2404-mingw/build/src/openvpn/run_command.c:123:9: error: 
implicit declaration of function ???WIFEXITED??? 
[-Werror=implicit-function-declaration]

```



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/855?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I81cbecd19018290d85c6c77fba7769f040d66233
Gerrit-Change-Number: 855
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Fri, 10 Jan 2025 07:26:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to