Attention is currently required from: flichtenheld, plaisthos, stipa.

ordex has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/856?usp=email )

Change subject: multi.c: add iroutes after dco peer is added
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Patchset:

PS1:
I confirm that dco on Linux does not care about the order because iroutes are 
just basic system routes. At first glance the change looks reasonable and 
without side effects.

Maybe Arne can confirm that changing the tls state before doing iroutes should 
not matter?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/856?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1cac0f036504c87205a3c97589a94a662cf79b99
Gerrit-Change-Number: 856
Gerrit-PatchSet: 1
Gerrit-Owner: stipa <lstipa...@gmail.com>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: ordex <a...@unstable.cc>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: stipa <lstipa...@gmail.com>
Gerrit-Comment-Date: Mon, 13 Jan 2025 09:29:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to