On 31/12/2024 21:46, Ben Boeckel via Openvpn-devel wrote:
Without this, the password request will expire after 90 seconds leaving
no way to provide the password without OpenVPN asking for it again.
Given that interactive use will wait for input without a timeout, it
makes sense to have non-interactive usage also wait until the user is
ready instead of forcing users to race against the timeout.
---
  src/openvpn/console_systemd.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/src/openvpn/console_systemd.c b/src/openvpn/console_systemd.c
index cc91cd10..b208a614 100644
--- a/src/openvpn/console_systemd.c
+++ b/src/openvpn/console_systemd.c
@@ -71,6 +71,7 @@ get_console_input_systemd(const char *prompt, const bool 
echo, char *input, cons
      }
  #endif
      argv_printf_cat(&argv, "--icon network-vpn");
+    argv_printf_cat(&argv, "--timeout=0");
      argv_printf_cat(&argv, "%s", prompt);
if ((std_out = openvpn_popen(&argv, NULL)) < 0)

Given the confirmation by Ben in this reply [1], I give this my ACK. I've also double checked the git commit log in systemd to verify his finding.

Acked-By: David Sommerseth <dav...@openvpn.net>


[1] <https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30362.html>


--
kind regards,

David Sommerseth
OpenVPN Inc



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to