Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/866?usp=email
to review the following change.
Change subject: console_systemd: remove the timeout when using
`systemd-ask-password`
......................................................................
console_systemd: remove the timeout when using `systemd-ask-password`
Without this, the password request will expire after 90 seconds leaving
no way to provide the password without OpenVPN asking for it again.
Given that interactive use will wait for input without a timeout, it
makes sense to have non-interactive usage also wait until the user is
ready instead of forcing users to race against the timeout.
Change-Id: I2791d09ab698d89dc7e0183151f77b84024ad6d1
Signed-off-by: Ben Boeckel <[email protected]>
Acked-By: David Sommerseth <[email protected]>
---
M src/openvpn/console_systemd.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/66/866/1
diff --git a/src/openvpn/console_systemd.c b/src/openvpn/console_systemd.c
index 858504d..91ebb35 100644
--- a/src/openvpn/console_systemd.c
+++ b/src/openvpn/console_systemd.c
@@ -72,6 +72,7 @@
}
#endif
argv_printf_cat(&argv, "--icon network-vpn");
+ argv_printf_cat(&argv, "--timeout=0");
argv_printf_cat(&argv, "%s", prompt);
if ((std_out = openvpn_popen(&argv, NULL)) < 0)
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/866?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2791d09ab698d89dc7e0183151f77b84024ad6d1
Gerrit-Change-Number: 866
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
