Attention is currently required from: flichtenheld, mrbff, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/870?usp=email )
Change subject: IPv6 MADDR LOG: Wrap IPv6 addresses in square brackets and include port when specified ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I think the patch is fine, technically, but I've spent a bit of thought on it, and want to suggest something else - in the MR_WITH_PORT case, use `"[%s]:%d"` - in the "naked IPv6 address" case, use `"%s"` only yes this is yet another extra `if()`, but my gut feeling is that it would help readability - and for parsers, it should not matter much. If the parser expects to see a port, it will always be `[]`, so no variations. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/870?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia58cff107d14e29e51df0a988e8337cbb70ebfbb Gerrit-Change-Number: 870 Gerrit-PatchSet: 1 Gerrit-Owner: mrbff <ma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: mrbff <ma...@mandelbit.com> Gerrit-Comment-Date: Fri, 17 Jan 2025 10:38:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
