Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/872?usp=email )
Change subject: Implement override-user ...................................................................... Patch Set 1: Code-Review-1 (16 comments) Patchset: PS1: Documentation review File Changes.rst: http://gerrit.openvpn.net/c/openvpn/+/872/comment/ccc7ee92_27cbfac3 : PS1, Line 41: client use certificates and multi-factor authentication. "clients" File doc/man-sections/server-options.rst: http://gerrit.openvpn.net/c/openvpn/+/872/comment/2cd1859d_57eca9b5 : PS1, Line 673: --override-username At the wrong place in the document alphabetically http://gerrit.openvpn.net/c/openvpn/+/872/comment/b9a8d3a6_1619c847 : PS1, Line 674: Sets the username of a connection the specified username. This username "to the" http://gerrit.openvpn.net/c/openvpn/+/872/comment/e61d54e2_2420a045 : PS1, Line 675: will also be used by the by ``--auth-gen-token``. However, the overridden Superfluous words "by the"? http://gerrit.openvpn.net/c/openvpn/+/872/comment/4c901590_e34fb4e7 : PS1, Line 677: ``--client-config-dir`` and the ``--auth-user-pass-verify`` script have This is confusing. Maybe: "after --client-config-dir has been read and the --client-connect and --auth-user-pass-verify scripts have been run." http://gerrit.openvpn.net/c/openvpn/+/872/comment/a2d45f6f_d858b939 : PS1, Line 680: Also ``username-as-common-name`` will use the client provided username --username-as-common-name for consistency http://gerrit.openvpn.net/c/openvpn/+/872/comment/9a5ed281_33dadded : PS1, Line 682: ``--override-username`` option if the option ``username-as-common-name`` superfluous space http://gerrit.openvpn.net/c/openvpn/+/872/comment/38f9af62_3921cd00 : PS1, Line 686: the the ``--auth-gen-token`` option. It will also be pushed to the client duplicated "the" http://gerrit.openvpn.net/c/openvpn/+/872/comment/3b589338_48d21540 : PS1, Line 687: using ``--auth-token-user``. We should add a cross-reference to documentation for --auth-token-user File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/872/comment/4e08bcdb_c5d535f5 : PS1, Line 2670: * @param mi Either document it or remove stub-comment. File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/872/comment/b78b8ba7_6bcff71d : PS1, Line 7850: else if (streq(p[0], "override-username") && p[1] && !p[2]) New option should be added to usage information. http://gerrit.openvpn.net/c/openvpn/+/872/comment/5d357a53_801e96ab : PS1, Line 7859: * set another username might serious problems */ missing word "cause"? File src/openvpn/ssl_common.h: http://gerrit.openvpn.net/c/openvpn/+/872/comment/77deffca_cb68f2dd : PS1, Line 630: * authentication */ "unless overridden by override-user" http://gerrit.openvpn.net/c/openvpn/+/872/comment/8fe0507f_ef4f018d : PS1, Line 633: /** The username that client initial used before being overrriden by "initially" http://gerrit.openvpn.net/c/openvpn/+/872/comment/47888316_35ac5086 : PS1, Line 634: * by override-user */ duplicated "by" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/872?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia4095518d5e4447992a2974e0d7a159d79ba6b6f Gerrit-Change-Number: 872 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Mon, 20 Jan 2025 12:36:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
