From: Gianmarco De Gregori <gianma...@mandelbit.com>
Fix issue reported by Coverity:
CID 1641424: Performance inefficiencies (PASS_BY_VALUE)
Passing parameter ce of type "struct connection_entry"
(size 208 bytes) by value, which exceeds the low
threshold of 128 bytes.
Commit 8466c2ca unintentionally introduced a performance
penalty due to passing struct connection_entry 'ce'
by value to options_postprocess_mutate_le().
fix this by passing 'ce' by address.
Change-Id: I0542df021ae0ba9c982335fed7bbd10ed326dd0f
Signed-off-by: Gianmarco De Gregori <gianma...@mandelbit.com>
Acked-by: Gert Doering <g...@greenie.muc.de>
---
This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/875
This mail reflects revision 1 of this Change.
Acked-by according to Gerrit (reflected above):
Gert Doering <g...@greenie.muc.de>
diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index c938999..bd5c056 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -3323,12 +3323,12 @@
}
static void
-options_postprocess_mutate_le(struct connection_entry ce, struct local_entry
*le)
+options_postprocess_mutate_le(struct connection_entry *ce, struct local_entry
*le)
{
/* use the global port if none is specified */
if (!le->port)
{
- le->port = ce.local_port;
+ le->port = ce->local_port;
}
}
@@ -3777,7 +3777,7 @@
{
for (i = 0; i < o->ce.local_list->len; i++)
{
- options_postprocess_mutate_le(o->ce, o->ce.local_list->array[i]);
+ options_postprocess_mutate_le(&o->ce, o->ce.local_list->array[i]);
}
}
else
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
